-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deposition): submit EMBL flatfile instead of fasta for better nucleotide metadata #2947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-parker
force-pushed
the
test_adding_authors
branch
2 times, most recently
from
October 4, 2024 08:22
b9b0177
to
d78cce0
Compare
anna-parker
force-pushed
the
test_adding_authors
branch
from
October 4, 2024 11:56
5153615
to
3d078fa
Compare
corneliusroemer
changed the title
Test adding authors
feat(deposition): submit EMBL flatfile instead of fasta for better nucleotide metadata
Oct 4, 2024
anna-parker
commented
Oct 4, 2024
corneliusroemer
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #
preview URL: https://test-adding-authors.loculus.org/
Summary
Adding AUTHORS as a field to the manifest file was not successful, from reading the docs it has become clear to us that instead of submitting the sequence as a fasta we should submit a flat file, flat files allow us to set metadata fields and the authors field.
Docs: https://ena-docs.readthedocs.io/en/latest/submit/fileprep/flat-file-example.html
Flat file: annotations: https://www.ebi.ac.uk/ena/WebFeat/.
As we are submitting as a broker it is important that we add the AUTHORS to the assembly: https://ena-docs.readthedocs.io/en/latest/faq/data_brokering.html#authorship.
Screenshot
PR Checklist